Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: on_kernel_start triggers callback on virtual kernel start #471

Conversation

maartenbreddels
Copy link
Contributor

No description provided.

Copy link
Contributor Author

maartenbreddels commented Jan 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maartenbreddels and the rest of your teammates on Graphite Graphite

Copy link
Contributor Author

@maartenbreddels maartenbreddels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some rewording, if you agree, feel free to merge the suggestions

solara/website/pages/api/on_kernel_start.py Outdated Show resolved Hide resolved
solara/website/pages/api/on_kernel_start.py Outdated Show resolved Hide resolved
solara/website/pages/api/on_kernel_start.py Outdated Show resolved Hide resolved
solara/website/pages/api/on_kernel_start.py Outdated Show resolved Hide resolved
Co-authored-by: Maarten Breddels <[email protected]>
@iisakkirotko iisakkirotko force-pushed the 01-18-feat_on_kernel_start_triggers_callback_on_virtual_kernel_start branch from 5518aea to e26db2f Compare February 8, 2024 15:32
@iisakkirotko iisakkirotko merged commit f60f68e into master Feb 8, 2024
24 checks passed
maartenbreddels added a commit that referenced this pull request Mar 14, 2024
Introduced in #471
We should remove the on_kernel_start callbacks on a hot reload, but
not remove the ones added by the hot reload itself.
maartenbreddels added a commit that referenced this pull request Mar 14, 2024
Introduced in #471
We should remove the on_kernel_start callbacks on a hot reload, but
not remove the ones added by the hot reload itself.
maartenbreddels added a commit that referenced this pull request Mar 25, 2024
Introduced in #471
We should remove the on_kernel_start callbacks on a hot reload, but
not remove the ones added by the hot reload itself.
maartenbreddels added a commit that referenced this pull request Mar 25, 2024
Introduced in #471
We should remove the on_kernel_start callbacks on a hot reload, but
not remove the ones added by the hot reload itself.
maartenbreddels added a commit that referenced this pull request Mar 25, 2024
Introduced in #471
We should remove the on_kernel_start callbacks on a hot reload, but
not remove the ones added by the hot reload itself.
maartenbreddels added a commit that referenced this pull request Mar 25, 2024
Introduced in #471
We should remove the on_kernel_start callbacks on a hot reload, but
not remove the ones added by the hot reload itself.
maartenbreddels added a commit that referenced this pull request Mar 25, 2024
Introduced in #471
We should remove the on_kernel_start callbacks on a hot reload, but
not remove the ones added by the hot reload itself.
maartenbreddels added a commit that referenced this pull request Mar 25, 2024
Introduced in #471
We should remove the on_kernel_start callbacks on a hot reload, but
not remove the ones added by the hot reload itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants